Travel Mapping

User Discussions => Other Discussion => Topic started by: Jim on December 18, 2016, 12:27:13 pm

Title: Top priorities for Christmas break
Post by: Jim on December 18, 2016, 12:27:13 pm
I am aiming to be able to put in a little time on TM this week beyond just the routine site updates.  I'll look through the forum and GitHub issues to find things that seem most urgent.  If you want to direct my attention to something that is high priority from your perspective, a quick post here (ideally just a link to a forum topic and/or GitHub issue) can help draw my attention.
Title: Re: Top priorities for Christmas break
Post by: michih on December 18, 2016, 01:40:17 pm
I think "urgent" means improvements and bug fixes only, no features. My list:

1. Update page
We discussed it but I cannot find it now. IIRC you wanna have a updates.csv per region so that you don't have to make the update entries and that the list can be sorted on the site et cetera. I think that both lists (http://tm.teresco.org/devel/updates.php) are already too long. Not good for less experienced/new user

2. Developer link page (https://github.com/TravelMapping/Web/issues/106)
I think it's less effort

3. HB: Incorrect values in % column (traveled) (https://github.com/TravelMapping/Web/issues/103)
There are more reports about data processing issues, e.g. this (http://tm.teresco.org/forum/index.php?topic=1847) or this (https://github.com/TravelMapping/Web/issues/74), maybe this (https://github.com/TravelMapping/Web/issues/91).
Title: Re: Top priorities for Christmas break
Post by: Jim on December 18, 2016, 03:09:17 pm
Bug fixes should take priority but mention feature requests also if you'd like.  Some might be possible.
Title: Re: Top priorities for Christmas break
Post by: michih on December 18, 2016, 03:32:12 pm
Well, my biggest wish is opening Highway Browser for specific routes from the map (https://github.com/TravelMapping/Web/issues/95) :)
Title: Re: Top priorities for Christmas break
Post by: si404 on December 18, 2016, 03:55:10 pm
intersecting routes linked to on the hb (per CHM)
Title: Re: Top priorities for Christmas break
Post by: yakra on December 18, 2016, 08:03:28 pm
intersecting routes linked to on the hb (per CHM)
I've always liked the idea of having this as an option, say a drop-down menu, from the info window after clicking on a waypoint.
Title: Re: Top priorities for Christmas break
Post by: mvak36 on December 19, 2016, 10:30:52 am
If time permits, maybe this (http://tm.teresco.org/forum/index.php?topic=265.0). I'm not sure how long something like this would take though. So if it takes too long, I wouldn't worry about it.
Title: Re: Top priorities for Christmas break
Post by: si404 on December 19, 2016, 01:29:11 pm
I've always liked the idea of having this as an option, say a drop-down menu, from the info window after clicking on a waypoint.
It could just go on the info window that comes from clicking. Drop-down is extra work for both coder and user.

But that does seem the best place to put it.
Title: Re: Top priorities for Christmas break
Post by: yakra on December 19, 2016, 03:24:37 pm
True, but I'm worried about the InfoWindow becoming too visually "busy". Think Maine, Oklahoma, Indianapolis, or a few places in Arkansas... I'd prefer to keep the InfoWindow cleaner; I think it's worth the price of an extra click.
Title: Re: Top priorities for Christmas break
Post by: yakra on December 19, 2016, 03:30:51 pm
Suggestion: some of the stuff discussed in the nearmisspoints.log and tm-master.nmp (http://tm.teresco.org/forum/index.php?topic=335) thread
Title: Re: Top priorities for Christmas break
Post by: mapcat on December 19, 2016, 03:57:56 pm
The bug reported here: http://tm.teresco.org/forum/index.php?topic=1847.0 (http://tm.teresco.org/forum/index.php?topic=1847.0)

(difference between clinched mileage on different pages)
Title: Re: Top priorities for Christmas break
Post by: Rothman on December 20, 2016, 09:54:08 am
Clicking on "Routes Driven" or "Routes Clinched" takes you to strange pages/maps currently.  Not sure what's intended there (somehow show ranks, maybe?).  Are the links even supposed to be there?
Title: Re: Top priorities for Christmas break
Post by: yakra on December 20, 2016, 12:38:57 pm
Clicking on "Routes Driven" or "Routes Clinched" takes you to strange pages/maps currently.  Not sure what's intended there (somehow show ranks, maybe?).  Are the links even supposed to be there?
Is this the page you're referring to?
http://tm.teresco.org/shields/clinched.php?u=yakra
Title: Re: Top priorities for Christmas break
Post by: Rothman on December 20, 2016, 01:06:59 pm
Clicking on "Routes Driven" or "Routes Clinched" takes you to strange pages/maps currently.  Not sure what's intended there (somehow show ranks, maybe?).  Are the links even supposed to be there?
Is this the page you're referring to?
http://tm.teresco.org/shields/clinched.php?u=yakra

I meant on the system stats table (http://tm.teresco.org/user/system.php?u=dnthrox&sys=usai).  Sorry about that.  I appear to be in rare form today.
Title: Re: Top priorities for Christmas break
Post by: michih on December 20, 2016, 01:14:34 pm
@Rothman, both (routes driven/routes clinched) link to the same map: http://tm.teresco.org/user/mapview.php?u=&sys=usai. Dunno what the map should show...
Title: Re: Top priorities for Christmas break
Post by: Rothman on December 20, 2016, 03:04:24 pm
@Rothman, both (routes driven/routes clinched) link to the same map: http://tm.teresco.org/user/mapview.php?u=&sys=usai. Dunno what the map should show...

Right, that's my point:  What are the links for and will whatever purpose that is be implemented?  Otherwise, why have them if they're not really needed? 
Title: Re: Top priorities for Christmas break
Post by: yakra on December 20, 2016, 03:25:21 pm
Interesting. Both routes driven/routes clinched link to clinched.php (http://tm.teresco.org/shields/clinched.php?u=yakra), from the Overall Region Stats table in region.php (http://tm.teresco.org/user/region.php?u=yakra&rg=ME). I imagine that this is what was intended for system.php, but the author just goofed.
Title: Re: Top priorities for Christmas break
Post by: Jim on December 20, 2016, 04:07:20 pm
We had a bad variable in the construction of the link (missing user).   It at least now links to the mapview.php equivalent of the system.php page.  Same user and system.  Not sure it's super useful but at least it's not broken.  Thanks for pointing it out.
Title: Re: Top priorities for Christmas break
Post by: yakra on December 20, 2016, 06:30:49 pm
I suggest linking it to clinched.php instead. It looks like this was the original intent, based on what I see in region.php
Title: Re: Top priorities for Christmas break
Post by: Jim on December 20, 2016, 07:50:55 pm
I suggest linking it to clinched.php instead. It looks like this was the original intent, based on what I see in region.php

Done.  That page doesn't honor sys= at this time so it shows all of a user's clinched routes.
Title: Re: Top priorities for Christmas break
Post by: mapcat on December 20, 2016, 08:42:57 pm
Shouldn't the link from "routes driven" link to clinched.php?u=[username]&cort=traveled instead?
Title: Re: Top priorities for Christmas break
Post by: michih on December 21, 2016, 04:23:20 am
Shouldn't the link from "routes driven" link to clinched.php?u=[username]&cort=traveled instead?

Yes, it's still not like intended. Both (routes driven / routes clinched) still have the same result/link.
Title: Re: Top priorities for Christmas break
Post by: Rothman on December 21, 2016, 11:46:56 am
I suppose I might as well bring up another nitpick:

The column headings "Clinched Mileage," "Total Mileage," and "Percentage" in the Statistics per Route table on http://tm.teresco.org/user/system.php?u=dnthrox&sys=usai do not sort when clicked in Chrome or IE for me.  Statistics per Region does sort properly.

Easy enough to bring it over into Excel, though.
Title: Re: Top priorities for Christmas break
Post by: mapcat on December 21, 2016, 12:04:45 pm
I suppose I might as well bring up another nitpick:

The column headings "Clinched Mileage," "Total Mileage," and "Percentage" in the Statistics per Route table on http://tm.teresco.org/user/system.php?u=dnthrox&sys=usai do not sort when clicked in Chrome or IE for me.  Statistics per Region does sort properly.

Easy enough to bring it over into Excel, though.

Already reported here: http://tm.teresco.org/forum/index.php?topic=466.0

And a GitHub issue: https://github.com/TravelMapping/Web/issues/112
Title: Re: Top priorities for Christmas break
Post by: Jim on December 21, 2016, 09:38:59 pm
I suppose I might as well bring up another nitpick:

The column headings "Clinched Mileage," "Total Mileage," and "Percentage" in the Statistics per Route table on http://tm.teresco.org/user/system.php?u=dnthrox&sys=usai do not sort when clicked in Chrome or IE for me.  Statistics per Region does sort properly.

Easy enough to bring it over into Excel, though.

Looked into this a bit.  No resolution.  https://github.com/TravelMapping/Web/issues/112
Title: Re: Top priorities for Christmas break
Post by: Jim on December 22, 2016, 08:49:04 am
2. Developer link page (https://github.com/TravelMapping/Web/issues/106)
I think it's less effort

First draft:

http://tmtest.teresco.org/devel/tools.php
 (http://tmtest.teresco.org/devel/tools.php)

Note that the log file links will need to be changed to tm.teresco.org, which will they will already be when this goes to production.  I don't want to hard-code that URL.  I want to keep the links relative.
Title: Re: Top priorities for Christmas break
Post by: michih on December 22, 2016, 09:35:09 am
Thanks, I like it :)

Comments:
- Data check is redundant in the footer now
- I would not distinguish "TM Site Pages" and "Log Files" but "Highway Data Development Logs" and "Web Site Development and Site Update Logs" (data check page is also a info generated from log files)
- The link text should generally have better info for what it's used to or a 2nd line should describe it
- Redundant links in data check page should be removed now

Maybe like this:

Highway Data Development Logs

- Datacheck (Currently 58 errors in active systems)
     These errors should be corrected, or reported as false positives by adding the entry from the last column to the datacheck FP list.

- Datacheck false positive entries that did not correspond to any detected datacheck error
     Cleaning these up are low priority tasks for the project

- Datacheck entries that nearly match false positive entries
     These errors should be corrected, or reported as false positives by adding the entry to the nmpfps.log list.

- Travel Mapping Graph Data (http://tm.teresco.org/graphs/)
     Graphs can be loaded to the Highway Data Explorer to verify unexpected or broken concurrencies

- Log of points that are very close together and might be candidates to merge
 * Log format
 * tmp format (to be loaded to Highway Data Explorer for investigation)

- Full datacheck log file
     Contains........ ? ? ? ?

- List of unprocessed wpt files
     Waypoint files in the repository that are not processed because they are not listed in any highway system's csv files

- Waypoint labels in use by current TM users
     To be considered if wpt files of active systems are modified to avoid breaking user files, can be loaded to CHM's WPT file Editor


Web Site Development and Site Update Logs

- Complete output log from the site update process

- Log of highway data stats, useful to verify web code

- List of highway concurrencies detected
Title: Re: Top priorities for Christmas break
Post by: Jim on December 22, 2016, 09:53:53 am
Thanks for the suggestions.  I think I like them all.  I'm headed out for the day now and hopefully will implement these tonight or tomorrow.

Additional suggestions from everyone are welcome.
Title: Re: Top priorities for Christmas break
Post by: michih on January 07, 2017, 09:18:33 am
2. Developer link page (https://github.com/TravelMapping/Web/issues/106)
I think it's less effort

First draft:
http://tmtest.teresco.org/devel/tools.php
 (http://tmtest.teresco.org/devel/tools.php)

The first draft seems to be live now.
Title: Re: Top priorities for Christmas break
Post by: Jim on January 07, 2017, 01:53:13 pm
2. Developer link page (https://github.com/TravelMapping/Web/issues/106)
I think it's less effort

First draft:
http://tmtest.teresco.org/devel/tools.php
 (http://tmtest.teresco.org/devel/tools.php)

The first draft seems to be live now.

Not intentionally but yes.  I was going to implement the other suggestions first.  Hope to do those soon.
Title: Re: Top priorities for Christmas break
Post by: Jim on January 29, 2017, 10:40:04 pm
By "tonight or tomorrow" I guess I meant "in a little over a month", but I have a version of the developer tools page up that takes nearly all of the @michih suggestions a few posts back.  Further comments and suggestions welcome.
Title: Re: Top priorities for Christmas break
Post by: michih on January 30, 2017, 02:27:42 pm
Thanks. I think it's good enough for the time being.
Title: Re: Top priorities for Christmas break
Post by: michih on February 03, 2017, 03:51:08 pm
- Log of points that are very close together and might be candidates to merge
 * Log format
 * nmp format (to be loaded to Highway Data Explorer for investigation)

Is there any reason why the nmp file is not in the list or on the graphs page (http://tm.teresco.org/graphs/)? It's the more important one because it can be loaded to HDX...
Title: Re: Top priorities for Christmas break
Post by: Jim on February 03, 2017, 04:18:39 pm
- Log of points that are very close together and might be candidates to merge
 * Log format
 * nmp format (to be loaded to Highway Data Explorer for investigation)

Is there any reason why the nmp file is not in the list or on the graphs page (http://tm.teresco.org/graphs/)? It's the more important one because it can be loaded to HDX...

It's because the focus of that page is for the academic projects, who don't really care about NMP (at least I have not asked them to care about it).
Title: Re: Top priorities for Christmas break
Post by: michih on February 04, 2017, 03:38:05 am
I agree about graphs page but I think that the developer links page should get it...
Title: Re: Top priorities for Christmas break
Post by: Jim on February 04, 2017, 07:20:24 am
I agree about graphs page but I think that the developer links page should get it...

That's just an oversight.  It's there now, thanks.