Author Topic: Top priorities for Christmas break  (Read 1720 times)

0 Members and 1 Guest are viewing this topic.

Offline Rothman

  • Newbie
  • *
  • Posts: 14
  • Last Login:December 06, 2017, 11:48:33 pm
Re: Top priorities for Christmas break
« Reply #15 on: December 20, 2016, 03:04:24 pm »
@Rothman, both (routes driven/routes clinched) link to the same map: http://tm.teresco.org/user/mapview.php?u=&sys=usai. Dunno what the map should show...

Right, that's my point:  What are the links for and will whatever purpose that is be implemented?  Otherwise, why have them if they're not really needed? 

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1093
  • Last Login:Today at 02:05:46 am
Re: Top priorities for Christmas break
« Reply #16 on: December 20, 2016, 03:25:21 pm »
Interesting. Both routes driven/routes clinched link to clinched.php, from the Overall Region Stats table in region.php. I imagine that this is what was intended for system.php, but the author just goofed.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 935
  • Last Login:Yesterday at 10:16:35 pm
Re: Top priorities for Christmas break
« Reply #17 on: December 20, 2016, 04:07:20 pm »
We had a bad variable in the construction of the link (missing user).   It at least now links to the mapview.php equivalent of the system.php page.  Same user and system.  Not sure it's super useful but at least it's not broken.  Thanks for pointing it out.

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1093
  • Last Login:Today at 02:05:46 am
Re: Top priorities for Christmas break
« Reply #18 on: December 20, 2016, 06:30:49 pm »
I suggest linking it to clinched.php instead. It looks like this was the original intent, based on what I see in region.php

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 935
  • Last Login:Yesterday at 10:16:35 pm
Re: Top priorities for Christmas break
« Reply #19 on: December 20, 2016, 07:50:55 pm »
I suggest linking it to clinched.php instead. It looks like this was the original intent, based on what I see in region.php

Done.  That page doesn't honor sys= at this time so it shows all of a user's clinched routes.

Offline mapcat

  • TM Collaborator
  • Sr. Member
  • *****
  • Posts: 484
  • Last Login:Yesterday at 11:32:10 pm
Re: Top priorities for Christmas break
« Reply #20 on: December 20, 2016, 08:42:57 pm »
Shouldn't the link from "routes driven" link to clinched.php?u=[username]&cort=traveled instead?
Clinched:

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 896
  • Gender: Male
  • Last Login:Yesterday at 11:52:10 am
Re: Top priorities for Christmas break
« Reply #21 on: December 21, 2016, 04:23:20 am »
Shouldn't the link from "routes driven" link to clinched.php?u=[username]&cort=traveled instead?

Yes, it's still not like intended. Both (routes driven / routes clinched) still have the same result/link.

Offline Rothman

  • Newbie
  • *
  • Posts: 14
  • Last Login:December 06, 2017, 11:48:33 pm
Re: Top priorities for Christmas break
« Reply #22 on: December 21, 2016, 11:46:56 am »
I suppose I might as well bring up another nitpick:

The column headings "Clinched Mileage," "Total Mileage," and "Percentage" in the Statistics per Route table on http://tm.teresco.org/user/system.php?u=dnthrox&sys=usai do not sort when clicked in Chrome or IE for me.  Statistics per Region does sort properly.

Easy enough to bring it over into Excel, though.

Offline mapcat

  • TM Collaborator
  • Sr. Member
  • *****
  • Posts: 484
  • Last Login:Yesterday at 11:32:10 pm
Re: Top priorities for Christmas break
« Reply #23 on: December 21, 2016, 12:04:45 pm »
I suppose I might as well bring up another nitpick:

The column headings "Clinched Mileage," "Total Mileage," and "Percentage" in the Statistics per Route table on http://tm.teresco.org/user/system.php?u=dnthrox&sys=usai do not sort when clicked in Chrome or IE for me.  Statistics per Region does sort properly.

Easy enough to bring it over into Excel, though.

Already reported here: http://tm.teresco.org/forum/index.php?topic=466.0

And a GitHub issue: https://github.com/TravelMapping/Web/issues/112
Clinched:

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 935
  • Last Login:Yesterday at 10:16:35 pm
Re: Top priorities for Christmas break
« Reply #24 on: December 21, 2016, 09:38:59 pm »
I suppose I might as well bring up another nitpick:

The column headings "Clinched Mileage," "Total Mileage," and "Percentage" in the Statistics per Route table on http://tm.teresco.org/user/system.php?u=dnthrox&sys=usai do not sort when clicked in Chrome or IE for me.  Statistics per Region does sort properly.

Easy enough to bring it over into Excel, though.

Looked into this a bit.  No resolution.  https://github.com/TravelMapping/Web/issues/112

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 935
  • Last Login:Yesterday at 10:16:35 pm
Re: Top priorities for Christmas break
« Reply #25 on: December 22, 2016, 08:49:04 am »
2. Developer link page
I think it's less effort

First draft:

http://tmtest.teresco.org/devel/tools.php


Note that the log file links will need to be changed to tm.teresco.org, which will they will already be when this goes to production.  I don't want to hard-code that URL.  I want to keep the links relative.
« Last Edit: December 22, 2016, 08:52:06 am by Jim »

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 896
  • Gender: Male
  • Last Login:Yesterday at 11:52:10 am
Re: Top priorities for Christmas break
« Reply #26 on: December 22, 2016, 09:35:09 am »
Thanks, I like it :)

Comments:
- Data check is redundant in the footer now
- I would not distinguish "TM Site Pages" and "Log Files" but "Highway Data Development Logs" and "Web Site Development and Site Update Logs" (data check page is also a info generated from log files)
- The link text should generally have better info for what it's used to or a 2nd line should describe it
- Redundant links in data check page should be removed now

Maybe like this:

Highway Data Development Logs

- Datacheck (Currently 58 errors in active systems)
     These errors should be corrected, or reported as false positives by adding the entry from the last column to the datacheck FP list.

- Datacheck false positive entries that did not correspond to any detected datacheck error
     Cleaning these up are low priority tasks for the project

- Datacheck entries that nearly match false positive entries
     These errors should be corrected, or reported as false positives by adding the entry to the nmpfps.log list.

- Travel Mapping Graph Data
     Graphs can be loaded to the Highway Data Explorer to verify unexpected or broken concurrencies

- Log of points that are very close together and might be candidates to merge
 * Log format
 * tmp format (to be loaded to Highway Data Explorer for investigation)

- Full datacheck log file
     Contains........ ? ? ? ?

- List of unprocessed wpt files
     Waypoint files in the repository that are not processed because they are not listed in any highway system's csv files

- Waypoint labels in use by current TM users
     To be considered if wpt files of active systems are modified to avoid breaking user files, can be loaded to CHM's WPT file Editor


Web Site Development and Site Update Logs

- Complete output log from the site update process

- Log of highway data stats, useful to verify web code

- List of highway concurrencies detected

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 935
  • Last Login:Yesterday at 10:16:35 pm
Re: Top priorities for Christmas break
« Reply #27 on: December 22, 2016, 09:53:53 am »
Thanks for the suggestions.  I think I like them all.  I'm headed out for the day now and hopefully will implement these tonight or tomorrow.

Additional suggestions from everyone are welcome.

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 896
  • Gender: Male
  • Last Login:Yesterday at 11:52:10 am

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 935
  • Last Login:Yesterday at 10:16:35 pm
Re: Top priorities for Christmas break
« Reply #29 on: January 07, 2017, 01:53:13 pm »
2. Developer link page
I think it's less effort

First draft:
http://tmtest.teresco.org/devel/tools.php

The first draft seems to be live now.

Not intentionally but yes.  I was going to implement the other suggestions first.  Hope to do those soon.