Author Topic: First attempt at km/mi selection  (Read 1080 times)

0 Members and 1 Guest are viewing this topic.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 989
  • Last Login:Yesterday at 10:24:16 pm
Re: First attempt at km/mi selection
« Reply #15 on: May 18, 2017, 12:03:40 am »
Table sorting is still hinky, regardless of unit (on user stats page, both by region and by system). That's all I've noticed.

I definitely haven't sorted out what's going on with that table sorting...  I think if I remove the thousands separator commas, things should at least be as good as they were before this round of tinkering.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 989
  • Last Login:Yesterday at 10:24:16 pm
Re: First attempt at km/mi selection
« Reply #16 on: May 18, 2017, 04:27:49 pm »
This is now live on the main site.  I haven't addressed the table sorting issues that were introduced by my adding in the thousands separators, but I'd like to leave them in for now.  Any volunteers to dive into the tablesorter library we use?  I am thinking a custom sorting comparator (or whatever the JS equivalent is called) will do it.

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 941
  • Gender: Male
  • Last Login:Yesterday at 01:13:10 pm
Re: First attempt at km/mi selection
« Reply #17 on: May 21, 2017, 02:53:20 am »
I haven't addressed the table sorting issues that were introduced by my adding in the thousands separators, but I'd like to leave them in for now.  Any volunteers to dive into the tablesorter library we use?  I am thinking a custom sorting comparator (or whatever the JS equivalent is called) will do it.

I've submitted an issue: https://github.com/TravelMapping/Web/issues/180

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 989
  • Last Login:Yesterday at 10:24:16 pm
Re: First attempt at km/mi selection
« Reply #18 on: May 21, 2017, 08:40:49 am »
I haven't addressed the table sorting issues that were introduced by my adding in the thousands separators, but I'd like to leave them in for now.  Any volunteers to dive into the tablesorter library we use?  I am thinking a custom sorting comparator (or whatever the JS equivalent is called) will do it.

I've submitted an issue: https://github.com/TravelMapping/Web/issues/180

Perfect, thanks.

Offline Thing342

  • Computer Guy
  • TM Collaborator
  • Newbie
  • *****
  • Posts: 13
  • Gender: Male
  • Last Login:June 08, 2017, 10:58:40 pm
  • V.T.C.S.
    • Personal Page
Re: First attempt at km/mi selection
« Reply #19 on: June 02, 2017, 01:07:13 pm »
This is now live on the main site.  I haven't addressed the table sorting issues that were introduced by my adding in the thousands separators, but I'd like to leave them in for now.  Any volunteers to dive into the tablesorter library we use?  I am thinking a custom sorting comparator (or whatever the JS equivalent is called) will do it.
(sorry about my periodic absence, having been managing school + a full time job)

I generally try to avoid wading in the depths of JavaScript, but I would be in favor of completely replacing the library currently in use, as it's a janky, barely-documented jQuery thing that I used because it was quick and easy. I think we should maybe try for a more encompassing table library, such as https://datatables.net/ for a more consistent UX.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 989
  • Last Login:Yesterday at 10:24:16 pm
Re: First attempt at km/mi selection
« Reply #20 on: June 02, 2017, 02:30:52 pm »
I generally try to avoid wading in the depths of JavaScript, but I would be in favor of completely replacing the library currently in use, as it's a janky, barely-documented jQuery thing that I used because it was quick and easy. I think we should maybe try for a more encompassing table library, such as https://datatables.net/ for a more consistent UX.

Thanks.  One of my students currently working on the academic project side of this is looking into some options for better tables on that end, and I expect we'll find something appropriate to move back to the TM side.  I'll point her to https://datatables.net/ as one of the options to evaluate.

Offline Thing342

  • Computer Guy
  • TM Collaborator
  • Newbie
  • *****
  • Posts: 13
  • Gender: Male
  • Last Login:June 08, 2017, 10:58:40 pm
  • V.T.C.S.
    • Personal Page
Re: First attempt at km/mi selection
« Reply #21 on: June 02, 2017, 04:14:14 pm »
Thanks.  One of my students currently working on the academic project side of this is looking into some options for better tables on that end, and I expect we'll find something appropriate to move back to the TM side.  I'll point her to https://datatables.net/ as one of the options to evaluate.

I created an issue for it: https://github.com/TravelMapping/Web/issues/183

I've been working on a proof-of-concept with it, but if your student wishes to work more on it, i'll yield to you.
« Last Edit: June 02, 2017, 04:18:22 pm by Thing342 »